War can be declared before attacks are allowed

[I_like_pie]

War declaration is an act of aggression and shouldn’t be possible before attacks are allowed.

Due to an unrelated timing bug, this leads to scenarios like below where a family loses the element of surprise.

@Darrk

We couldn’t attack for several ticks after T-72.

The timing bug will need to be fixed as well, but it would have been a good failsafe if the rules for war declaration matched the rules for attacks.

---

Follow the status of this bug in The Roadmap.

[Darrk]

@I_like_pie

The timing bug will need to be fixed as well, but it would have been a good failsafe if the rules for war declaration matched the rules for attacks.

Back for 4 days and just breaking stuff.
I am why we can’t have nice things.

[I_like_pie]

This has been fixed; when attempting to declare while a delay is active, the following message will be returned:

Also, a smaller related bug was fixed where intra-fam attacks also ignored the SoR delay.